Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on linus/master v6.2-rc5 next-20230123] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-Hewitt/media-meson-vdec-implement-10bit-bitstream-handling/20230123-213323 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230123133113.3254659-3-christianshewitt%40gmail.com patch subject: [PATCH 2/2] media: meson: vdec: add HEVC decode codec config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230124/202301240007.NkZA19qq-lkp@xxxxxxxxx/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/498d420e9c7cdc6e694be643c47ee69c8b5b2142 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Christian-Hewitt/media-meson-vdec-implement-10bit-bitstream-handling/20230123-213323 git checkout 498d420e9c7cdc6e694be643c47ee69c8b5b2142 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/staging/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/staging/media/meson/vdec/codec_hevc.c: In function 'codec_hevc_set_mpred_mv': >> drivers/staging/media/meson/vdec/codec_hevc.c:1002:13: warning: variable 'val' set but not used [-Wunused-but-set-variable] 1002 | u32 val; | ^~~ vim +/val +1002 drivers/staging/media/meson/vdec/codec_hevc.c 990 991 static void codec_hevc_set_mpred_mv(struct amvdec_core *core, 992 struct codec_hevc *hevc, 993 struct hevc_frame *frame, 994 struct hevc_frame *col_frame) 995 { 996 union rpm_param *param = &hevc->rpm_param; 997 u32 lcu_size_log2 = ilog2(hevc->lcu_size); 998 u32 mv_mem_unit = lcu_size_log2 == 6 ? 0x200 : 999 lcu_size_log2 == 5 ? 0x80 : 0x20; 1000 dma_addr_t col_mv_rd_start_addr, col_mv_rd_ptr, col_mv_rd_end_addr; 1001 dma_addr_t mpred_mv_wr_ptr; > 1002 u32 val; 1003 1004 val = amvdec_read_dos(core, HEVC_MPRED_CURR_LCU); 1005 1006 col_mv_rd_start_addr = codec_hevc_get_frame_mv_paddr(hevc, col_frame); 1007 mpred_mv_wr_ptr = codec_hevc_get_frame_mv_paddr(hevc, frame) + 1008 (hevc->slice_addr * mv_mem_unit); 1009 col_mv_rd_ptr = col_mv_rd_start_addr + 1010 (hevc->slice_addr * mv_mem_unit); 1011 col_mv_rd_end_addr = col_mv_rd_start_addr + 1012 (hevc->lcu_total * mv_mem_unit); 1013 1014 amvdec_write_dos(core, HEVC_MPRED_MV_WR_START_ADDR, 1015 codec_hevc_get_frame_mv_paddr(hevc, frame)); 1016 amvdec_write_dos(core, HEVC_MPRED_MV_RD_START_ADDR, 1017 col_mv_rd_start_addr); 1018 1019 if (param->p.slice_segment_address == 0) { 1020 amvdec_write_dos(core, HEVC_MPRED_ABV_START_ADDR, 1021 hevc->workspace_paddr + MPRED_ABV_OFFSET); 1022 amvdec_write_dos(core, HEVC_MPRED_MV_WPTR, mpred_mv_wr_ptr); 1023 amvdec_write_dos(core, HEVC_MPRED_MV_RPTR, 1024 col_mv_rd_start_addr); 1025 } else { 1026 amvdec_write_dos(core, HEVC_MPRED_MV_RPTR, col_mv_rd_ptr); 1027 } 1028 1029 amvdec_write_dos(core, HEVC_MPRED_MV_RD_END_ADDR, col_mv_rd_end_addr); 1030 } 1031 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
