Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on sailus-media-tree/streams linus/master v6.2-rc5 next-20230120] [cannot apply to pza/reset/next pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-verisilicon-HEVC-Only-propose-10-bits-compatible-pixels-formats/20230119-164844 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230119084723.133576-1-benjamin.gaignard%40collabora.com patch subject: [PATCH v3] media: verisilicon: HEVC: Only propose 10 bits compatible pixels formats config: arm-randconfig-r022-20230122 (https://download.01.org/0day-ci/archive/20230123/202301230653.0LvIKTcP-lkp@xxxxxxxxx/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/11b698515c987afb9699f60be773dd7c52cea592 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Gaignard/media-verisilicon-HEVC-Only-propose-10-bits-compatible-pixels-formats/20230119-164844 git checkout 11b698515c987afb9699f60be773dd7c52cea592 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/media/platform/verisilicon/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/media/platform/verisilicon/hantro_drv.c:20: In file included from include/linux/videodev2.h:61: include/uapi/linux/videodev2.h:1779:2: warning: field within 'struct v4l2_ext_control' is less aligned than 'union v4l2_ext_control::(anonymous at include/uapi/linux/videodev2.h:1779:2)' and is usually due to 'struct v4l2_ext_control' being packed, which can lead to unaligned accesses [-Wunaligned-access] union { ^ >> drivers/media/platform/verisilicon/hantro_drv.c:293:3: error: expected expression const struct v4l2_ctrl_hevc_sps *sps = ctrl->p_new.p_hevc_sps; ^ >> drivers/media/platform/verisilicon/hantro_drv.c:294:19: error: use of undeclared identifier 'sps' int bit_depth = sps->bit_depth_luma_minus8 + 8; ^ drivers/media/platform/verisilicon/hantro_drv.c:294:7: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement] int bit_depth = sps->bit_depth_luma_minus8 + 8; ^ drivers/media/platform/verisilicon/hantro_drv.c:1004:46: warning: implicit conversion from 'unsigned long long' to 'unsigned int' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:76:40: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^~~~~ 3 warnings and 2 errors generated. vim +293 drivers/media/platform/verisilicon/hantro_drv.c 281 282 static int hantro_hevc_s_ctrl(struct v4l2_ctrl *ctrl) 283 { 284 struct hantro_ctx *ctx; 285 286 ctx = container_of(ctrl->handler, 287 struct hantro_ctx, ctrl_handler); 288 289 vpu_debug(1, "s_ctrl: id = %d, val = %d\n", ctrl->id, ctrl->val); 290 291 switch (ctrl->id) { 292 case V4L2_CID_STATELESS_HEVC_SPS: > 293 const struct v4l2_ctrl_hevc_sps *sps = ctrl->p_new.p_hevc_sps; > 294 int bit_depth = sps->bit_depth_luma_minus8 + 8; 295 296 if (ctx->bit_depth != bit_depth) { 297 ctx->bit_depth = bit_depth; 298 return hantro_reset_raw_fmt(ctx); 299 } 300 break; 301 default: 302 return -EINVAL; 303 } 304 305 return 0; 306 } 307 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
