Hi Rob, On 1/18/23 16:48, Rob Herring wrote: > On Wed, Jan 18, 2023 at 11:32:38AM +0100, Michael Riesch wrote: >> Add devicetree binding for the Sony IMX415 CMOS image sensor. >> >> Signed-off-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> >> --- >> .../bindings/media/i2c/sony,imx415.yaml | 120 ++++++++++++++++++ >> MAINTAINERS | 7 + >> 2 files changed, 127 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml >> new file mode 100644 >> index 000000000000..ae54834a2341 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml >> @@ -0,0 +1,120 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/i2c/sony,imx415.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Sony IMX415 CMOS Image Sensor >> + >> +maintainers: >> + - Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> >> + >> +description: |- >> + The Sony IMX415 is a diagonal 6.4 mm (Type 1/2.8) CMOS active pixel type >> + solid-state image sensor with a square pixel array and 8.46 M effective >> + pixels. This chip operates with analog 2.9 V, digital 1.1 V, and interface >> + 1.8 V triple power supply, and has low power consumption. >> + The IMX415 is programmable through I2C interface. The sensor output is >> + available via CSI-2 serial data output (two or four lanes). >> + >> +allOf: >> + - $ref: ../video-interface-devices.yaml# >> + >> +properties: >> + compatible: >> + const: sony,imx415 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + description: Input clock (24 MHz, 27 MHz, 37.125 MHz, 72 MHz or 74.25 MHz) >> + items: >> + - const: inck >> + >> + avdd-supply: >> + description: Analog power supply (2.9 V) >> + >> + dvdd-supply: >> + description: Digital power supply (1.1 V) >> + >> + ovdd-supply: >> + description: Interface power supply (1.8 V) >> + >> + reset-gpios: >> + description: Sensor reset (XCLR) GPIO >> + maxItems: 1 >> + >> + flash-leds: true >> + >> + lens-focus: true >> + >> + orientation: true >> + >> + rotation: true >> + >> + port: >> + $ref: /schemas/graph.yaml#/properties/port > > /properties/port is for when there are no extra properties. You need > /$defs/port-base here since there are extra properties in the endpoint > node. Aaahhh, thanks for the pointer! I was really out of ideas what causes this error. dt_binding_check now completes successfully. I'll fix it in v2. Best regards, Michael > >> + >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + data-lanes: true >> + link-frequencies: true >> + >> + required: >> + - data-lanes >> + - link-frequencies >> + >> + required: >> + - endpoint >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - avdd-supply >> + - dvdd-supply >> + - ovdd-supply >> + - port >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + imx415: camera-sensor@1a { >> + compatible = "sony,imx415"; >> + reg = <0x1a>; >> + avdd-supply = <&vcc2v9_cam>; >> + clocks = <&clock_cam>; >> + clock-names = "inck"; >> + dvdd-supply = <&vcc1v1_cam>; >> + ovdd-supply = <&vcc1v8_cam>; >> + lens-focus = <&vcm>; >> + rotation = <180>; >> + orientation = <2>; >> + reset-gpios = <&gpio_expander 14 GPIO_ACTIVE_LOW>; >> + >> + port { >> + imx415_ep: endpoint { >> + remote-endpoint = <&mipi_in>; >> + clock-lanes = <0>; >> + data-lanes = <1 2>; >> + }; >> + }; >> + }; >> + }; >> +... >> diff --git a/MAINTAINERS b/MAINTAINERS >> index f61eb221415b..c9fa893bf649 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19493,6 +19493,13 @@ T: git git://linuxtv.org/media_tree.git >> F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml >> F: drivers/media/i2c/imx412.c >> >> +SONY IMX415 SENSOR DRIVER >> +M: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> >> +L: linux-media@xxxxxxxxxxxxxxx >> +S: Maintained >> +T: git git://linuxtv.org/media_tree.git >> +F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml >> + >> SONY MEMORYSTICK SUBSYSTEM >> M: Maxim Levitsky <maximlevitsky@xxxxxxxxx> >> M: Alex Dubov <oakad@xxxxxxxxx> >> -- >> 2.30.2 >>
