On Tue, Jan 17, 2023 at 01:31:52PM -0500, Brent Pappas wrote: Read to the end this message, please! > Replace the function-like macros FPNTBL_BYTES, SCTBL_BYTES, and > MORPH_PLANE_BYTES with static inline functions to comply with Linux coding > style standards. > Replace multiplication with calls to size_mul to prevent accidental > arithmetic overflow. We refer to MACRO() and func() as depicted. Otherwise looks good. ... > Changelog: > V1 -> V2: Use size_mul to perform size_t multiplication without risk of > overflow. > Remove the inline keyword from function definitions. > > V2 -> V3: Add commit message. You missed my other comments. Please, read reply in full and address all reviewer's comments. -- With Best Regards, Andy Shevchenko