Hi Jai, On Wed, Dec 28, 2022 at 04:44:57PM +0530, Jai Luthra wrote: > 2x2 binning works fine for RAW10 capture, but for RAW8 1232p mode it > leads to corrupted frames [1][2]. > > Using the special 2x2 analog binning mode fixes the issue, but causes > artefacts for RAW10 1232p capture. So here we choose the binning mode > depending upon the frame format selected. > > As both binning modes work fine for 480p RAW8 and RAW10 capture, it can > share the same code path as 1232p for selecting binning mode. > > [1] https://forums.raspberrypi.com/viewtopic.php?t=332103 > [2] https://github.com/raspberrypi/libcamera-apps/issues/281 > > Fixes: 22da1d56e982 ("media: i2c: imx219: Add support for RAW8 bit bayer format") > Signed-off-by: Jai Luthra <j-luthra@xxxxxx> I'm afraid this no longer applies after Laurent's imx290 series. Could you rebase this on my master branch: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/> I'm about to push patches there, should be done in a few hours' time. -- Kind regards, Sakari Ailus
