Hi Krzysztof, Thank you for taking the time to help review, I would like to ask a modification as follows. On Mon, 2023-01-16 at 09:10 +0100, Krzysztof Kozlowski wrote: > > (snip) > On 16/01/2023 04:21, Moudy Ho wrote: > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > > aal.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > aal.yaml > > new file mode 100644 > > index 000000000000..d2e1b5245778 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > aal.yaml > > Filename should match compatible, unless you already expect this > binding > will cover other devices. If so, why not adding them now? > May I rename this file to "mediatek,mt8195-mdp3.yaml" > > (snip) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > > color.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > color.yaml > > new file mode 100644 > > index 000000000000..1d8aa5dc76b9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > color.yaml > > @@ -0,0 +1,63 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mdp3-color.yaml*__;Iw!!CTRNKA9wMg0ARbw!lcferrFFP-mshDHNL-rwJLgNKDrXF9fXoljpqL30k5YKTNvCwuC3webzR32VnQQoPeFvSvAewNkeupcT4mjdEwNEKP4V$ ; > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lcferrFFP-mshDHNL-rwJLgNKDrXF9fXoljpqL30k5YKTNvCwuC3webzR32VnQQoPeFvSvAewNkeupcT4mjdEz618JHq$ ; > > > > + > > +title: MediaTek Media Data Path 3 COLOR > > + > > +maintainers: > > + - Matthias Brugger <matthias.bgg@xxxxxxxxx> > > + - Moudy Ho <moudy.ho@xxxxxxxxxxxx> > > + > > +description: > > + One of Media Data Path 3 (MDP3) components used to adjust hue, > > luma and > > + saturation to get better picture quality. > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8195-mdp3-color > > This is exactly the same as previous file. Why do you split the > binding? > It really looks unnecessary. > > Probably all other files should be also squashed. > and convert all other bindings into individual compatible enums to squash all files? compatible: enum: - mediatek,mt8195-mdp3-color - mediatek,mt8195-mdp3-aal ... > > + > > + reg: > > + maxItems: 1 > > + > > + mediatek,gce-client-reg: > > + description: > > + The register of client driver can be configured by gce with > > 4 arguments > > + defined in this property, such as phandle of gce, subsys id, > > + register offset and size. > > + Each subsys id is mapping to a base address of display > > function blocks > > + register which is defined in the gce header > > + include/dt-bindings/gce/<chip>-gce.h. > > Full, real path please, so it could be validated with tools. > > > Best regards, > Krzysztof > Sincerely, Moudy
