Hi Laurent, Thanks for your patch. On 2023-01-14 23:46:50 +0200, Laurent Pinchart wrote: > The control handler is leaked in some probe-time error paths, as well as > in the remove path. Fix it. > > Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver") > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/media/i2c/max9286.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 701038d6d19b..13a986b88588 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -1122,6 +1122,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv) > static void max9286_v4l2_unregister(struct max9286_priv *priv) > { > fwnode_handle_put(priv->sd.fwnode); > + v4l2_ctrl_handler_free(&priv->ctrls); > v4l2_async_unregister_subdev(&priv->sd); > max9286_v4l2_notifier_unregister(priv); > } > -- > Regards, > > Laurent Pinchart > -- Kind Regards, Niklas Söderlund