Re: [RFC/PATCH v4 02/11] media: Media device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Saturday 28 August 2010 12:26:15 Hans Verkuil wrote:
> On Friday, August 20, 2010 17:29:04 Laurent Pinchart wrote:

[snip]

> > +struct media_device {
> > +	/* dev->driver_data points to this struct. */
> > +	struct device *dev;
> > +	struct media_devnode devnode;
> > +
> > +	u8 model[32];
> > +	u8 serial[32];
> > +	u8 bus_info[32];
> > +	u32 device_version;
> 
> I prefer hw_revision or possibly hw_device_revision. 'device' is too
> ambiguous. And 'revision' is more applicable to hardware than 'version'
> IMHO.

Agreed.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux