Re: [PATCH 1/4] media: ti/davinci: vpbe_osd: Drop empty platform remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 13, 2022 at 3:36 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/ti/davinci/vpbe_osd.c | 6 ------
>  1 file changed, 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/ti/davinci/vpbe_osd.c b/drivers/media/platform/ti/davinci/vpbe_osd.c
> index 32f7ef547c82..f6ea71c081d4 100644
> --- a/drivers/media/platform/ti/davinci/vpbe_osd.c
> +++ b/drivers/media/platform/ti/davinci/vpbe_osd.c
> @@ -1561,14 +1561,8 @@ static int osd_probe(struct platform_device *pdev)
>         return 0;
>  }
>
> -static int osd_remove(struct platform_device *pdev)
> -{
> -       return 0;
> -}
> -
>  static struct platform_driver osd_driver = {
>         .probe          = osd_probe,
> -       .remove         = osd_remove,
>         .driver         = {
>                 .name   = MODULE_NAME,
>         },
> --
> 2.38.1
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux