Hi Umang, On Wed, Jan 11, 2023 at 02:32:17PM +0530, Umang Jain wrote: > Hi all, > > Gentle ping for review, If it's needs more iterations or ready to be > accepted... I see that Stefan has tested the whole series. Florian is listed as the maintainer for vc04_services. Florian, do you want to review this series further, or can we merge it in v6.3 ? > On 12/23/22 5:53 PM, Umang Jain wrote: > > The series removes the custom return values from functions > > and replaces them with linux error codes. This address the TODO > > vchiq interface: > > * Get rid of custom function return values > > > > Changes in v3: > > - Drop fixes tag for 5/7 as suggested in review > > - Add Tested-by: by Stefan Wahren to the series > > > > Changes in V2: > > - Patch 3/7 now reports for specific errors like -ENOMEM, -EHOSTDOWN > > - Patch 5/7 reports -ENOTCONN instead of -EINVAL and adds a "Fixes" tag > > > > Umang Jain (7): > > staging: vc04_services: Replace vchiq_status return type to int > > staging: vc04_services: Drop VCHIQ_SUCCESS usage > > staging: vc04_services: Drop VCHIQ_ERROR usage > > staging: vc04_services: Drop VCHIQ_RETRY usage > > vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect > > staging: vc04_services: Drop enum vchiq_status remnants > > staging: vc04_services: vchiq: Drop custom return values from TODO > > > > .../bcm2835-audio/bcm2835-vchiq.c | 12 +- > > .../include/linux/raspberrypi/vchiq.h | 65 +++--- > > drivers/staging/vc04_services/interface/TODO | 5 - > > .../interface/vchiq_arm/vchiq_arm.c | 124 +++++----- > > .../interface/vchiq_arm/vchiq_arm.h | 12 +- > > .../interface/vchiq_arm/vchiq_core.c | 216 +++++++++--------- > > .../interface/vchiq_arm/vchiq_core.h | 18 +- > > .../interface/vchiq_arm/vchiq_dev.c | 36 +-- > > .../interface/vchiq_arm/vchiq_ioctl.h | 8 +- > > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 11 +- > > 10 files changed, 246 insertions(+), 261 deletions(-) -- Regards, Laurent Pinchart
