Hi,
On 1/4/23 09:21, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The recent conversion missed the Kconfig bit, so it can now
> end up in a link error on randconfig builds:
>
> ld.lld: error: undefined symbol: vb2_vmalloc_memops
>>>> referenced by atomisp_fops.c
>>>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a
>
> Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Mauro, can you pick this up and send it to Linus as a 6.1 fix?
Regards,
Hans
> ---
> drivers/staging/media/atomisp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> index 2c8d7fdcc5f7..c9bff98e5309 100644
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -14,7 +14,7 @@ config VIDEO_ATOMISP
> depends on VIDEO_DEV && INTEL_ATOMISP
> depends on PMIC_OPREGION
> select IOSF_MBI
> - select VIDEOBUF_VMALLOC
> + select VIDEOBUF2_VMALLOC
> select VIDEO_V4L2_SUBDEV_API
> help
> Say Y here if your platform supports Intel Atom SoC
