Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes:
> Signed-off-by: Philipp Wiesner <p.wiesner@xxxxxxxxx>
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
I would require a small change here.
I am using the testpattern for non regression tests. This change implies that
the test pattern can only be set up by module parameters, and blocks the usage
through V4L2 debug, registers, see below:
memset(&set_reg, 0, sizeof(set_reg));
set_reg.match.type = V4L2_CHIP_MATCH_I2C_ADDR;
set_reg.match.addr = 0x5d;
set_reg.reg = 0x148;
set_reg.val = test_pattern;
set_reg.size = 1;
if (test_pattern != -1)
if (-1 == xioctl (fd, VIDIOC_DBG_S_REGISTER, &set_reg)) {
fprintf (stderr, "%s could set test pattern %x\n",
dev_name, test_pattern);
exit (EXIT_FAILURE);
}
But, the idea is not bad. Therefore, I'd like you to change:
> + dev_dbg(&client->dev, "%s: using testpattern %d\n", __func__,
> + testpattern);
> +
> + if (!ret)
> + ret = mt9m111_reg_set(client,
> + MT9M111_TEST_PATTERN_GEN, pattern);
into
> + dev_dbg(&client->dev, "%s: using testpattern %d\n", __func__,
> + testpattern);
> +
> + if (!ret && pattern)
> + ret = mt9m111_reg_set(client,
> + MT9M111_TEST_PATTERN_GEN, pattern);
> +
This way, the V4L2 debug registers usage is still allowed, and your module
parameter works too.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
