Re: [PATCH v1 0/2] media: sun6i-csi: Fix format propagation in bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, 4 January 2023 16:22:13 GMT Laurent Pinchart wrote:
> Hello,
> 
> This small patch series fixes format propagation in the sun6i-csi-bridge
> subdev from sink pad to source pad. In order to do so, it uses the V4L2
> subdev active state provided by the V4L2 subdev core (patch 2/2), with a
> preparatory patch (1/2) that drops direct access to the bridge fields
> from the capture side.
> 
> I haven't tested the patches myself as I lack a hardware platform for
> this, but Adam (on CC) has successfully tested them. Adam, if you want
> to reply with a Tested-by tag, that would be appreciated.
> 
> Laurent Pinchart (2):
>   media: sun6i-csi: capture: Use subdev operation to access bridge
>     format
>   media: sun6i-csi: subdev: Use subdev active state to store active
>     format
> 
>  .../sunxi/sun6i-csi/sun6i_csi_bridge.c        | 211 ++++++++----------
>  .../sunxi/sun6i-csi/sun6i_csi_bridge.h        |   9 -
>  .../sunxi/sun6i-csi/sun6i_csi_capture.c       |  23 +-
>  3 files changed, 110 insertions(+), 133 deletions(-)
> 
> 
> base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2
Tested-by Adam Pigg <adam@xxxxxxxxxxx>

I have used these 2 patches, along with the other 5 here [1] to successfully
capture frames on the Pinephone rear camera (ov5640) using libcamera and its 
cam utility.

I will submit the other patches here shortly.

[1] https://github.com/sailfish-on-dontbeevil/kernel-megi/commits/pinephone-libcamera

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux