Hi Ricardo, On Fri, Dec 02, 2022 at 06:21:34PM +0100, Ricardo Ribalda wrote: > This patchset contains the fixes for the comments on "v10 of Fix > v4l2-compliance errors series". In particular to the patches > > -uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE > -uvcvideo: improve error handling in uvc_query_ctrl() > > And the patch: > -uvcvideo: Fix handling on Bitmask controls Patches 1/7, 3/7, 4/7 and 6/7 are fine (possibly with changes mentioned in my review comments that I can handle when applying). I can apply them to my tree already (with a minor conflict resolution between 2/7 and 3/7), but it may be easier for you to send a v3 of the whole series. Please let me know what you'd prefer. > To: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > > --- > Changes in v2: > - Include "Get menu names from framework series" > https://lore.kernel.org/r/20220920-standard-menues-v2-0-a35af3243c2f@xxxxxxxxxxxx > - Link to v1: https://lore.kernel.org/r/20220920-resend-v4l2-compliance-v1-0-81364c15229b@xxxxxxxxxxxx > > --- > Hans Verkuil (2): > media: uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE > media: uvcvideo: improve error logging in uvc_query_ctrl() > > Ricardo Ribalda (5): > media: uvcvideo: Return -EACCES for Wrong state error > media: uvcvideo: Do not return positive errors in uvc_query_ctrl() > media: uvcvideo: Fix handling on Bitmask controls > media: uvcvideo: Implement mask for V4L2_CTRL_TYPE_MENU > media: uvcvideo: Use standard names for menus > > drivers/media/usb/uvc/uvc_ctrl.c | 230 ++++++++++++++++++++++++++++--------- > drivers/media/usb/uvc/uvc_driver.c | 9 +- > drivers/media/usb/uvc/uvc_v4l2.c | 85 ++++++++++---- > drivers/media/usb/uvc/uvc_video.c | 15 +-- > drivers/media/usb/uvc/uvcvideo.h | 8 +- > include/uapi/linux/uvcvideo.h | 3 +- > 6 files changed, 258 insertions(+), 92 deletions(-) > --- > base-commit: 521a547ced6477c54b4b0cc206000406c221b4d6 > change-id: 20220920-resend-v4l2-compliance-4fdbe4fbd7b5 -- Regards, Laurent Pinchart
