On Sat, Dec 24, 2022 at 3:38 AM Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx> wrote: > > This patch serie changes the decoding mode from "exit on error" > to "keep decoding". Using this mode and re-enabling error detection > allow getting error resilience without loosing the ability to report > errors to userland. This have showed great results, but might be a > little more risky since this is not the mode that the reference code > uses and the documentation is very brief. With this in place, > userspace can chose to skip or display corrupted frames depending > on its application requirement. Previsouly, applicaiton would have > had no choice but to present the corrupted frames. > > Changes since V1: > - Removed merged patch > - Changed usage of pr_debug into v4l2_dbg > - Fix typos in commit messages and comments > > Nicolas Dufresne (5): > media: rkvdec: Disable H.264 error detection > media: rkvdec: Add an ops to check for decode errors > media: rkvdec: Fix RKVDEC_ERR_PKT_NUM macro > media: rkvdec: Re-enable H.264 error detection > rkvdec: Improve error handling Apart from the minor comments in patch 3, the series is Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> Do we need to add the check_error_info op for VP9? > drivers/staging/media/rkvdec/rkvdec-h264.c | 23 +++++++++++++-- > drivers/staging/media/rkvdec/rkvdec-regs.h | 2 +- > drivers/staging/media/rkvdec/rkvdec.c | 34 ++++++++++++++++++---- > drivers/staging/media/rkvdec/rkvdec.h | 2 ++ > 4 files changed, 51 insertions(+), 10 deletions(-) > > -- > 2.38.1 >
