On Fri, Dec 16, 2022 at 04:54:59PM +0100, Hans de Goede wrote: > On 12/16/22 14:43, Andy Shevchenko wrote: > > On Fri, Dec 16, 2022 at 12:30:07PM +0100, Hans de Goede wrote: ... > >> +EXPORT_SYMBOL_GPL(led_add_lookup); > > > >> +EXPORT_SYMBOL_GPL(led_remove_lookup); > > > > Wondering why we can't make at least those two to be namespaced from day 1, > > switching the LED subsystem code to use module namespaces is > a RFE which is independent of / orthogonal to this patchset. Adding new unnamespaced APIs only delays and increases a burden of the work. We can start already for the logically separated subset of API, no? That's why I asked about this. -- With Best Regards, Andy Shevchenko