On 07/12/2022 13:31, Krzysztof Kozlowski wrote: > On 07/12/2022 13:13, Sebastian Fricke wrote: >> From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> >> >> Add bindings for the wave5 chips&media codec driver >> >> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> >> Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> > > What's happening with this patch? Where is the changelog? Why it is v11 > and first time I see it? And why it is v11 with basic mistakes and lack > of testing?!? I would assume that v11 was already seen and tested... > > >> --- >> .../devicetree/bindings/cnm,wave5.yml | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/cnm,wave5.yml > > Wrong directory. It wasn't here at all before, so I am really confused > how this could happen. > > Subject: drop redundant pieces: yaml, devicetree and bindings. > > >> >> diff --git a/Documentation/devicetree/bindings/cnm,wave5.yml b/Documentation/devicetree/bindings/cnm,wave5.yml >> new file mode 100644 >> index 000000000000..01dddebb162e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/cnm,wave5.yml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/wave5.yaml# > > You clearly did not test them before sending. > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Chips&Media Wave 5 Series multi-standard codec IP >> + >> +maintainers: >> + - Nas Chung <nas.chung@xxxxxxxxxxxxxxx> >> + - Robert Beckett <bob.beckett@xxxxxxxxxxxxx> >> + - Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> >> + >> +description: |- >> + The Chips&Media WAVE codec IP is a multi format video encoder/decoder >> + >> +properties: >> + compatible: >> + anyOf: > > Please start from example-schema or other recently approved bindings. No > anyOf. > >> + - items: > > No items... > >> + - enum: >> + - cnm,cm511-vpu >> + - cnm,cm517-vpu >> + - cnm,cm521-vpu >> + - cnm,cm521c-vpu >> + - cnm,cm521c-dual-vpu > > What's the difference between this and one above? > >> + - cnm,cm521e1-vpu >> + - cnm,cm537-vpu One more question - why "vpu" suffixes? Best regards, Krzysztof
