On 2022/12/7 5:04, Laurent Pinchart wrote:
On Tue, Dec 06, 2022 at 03:22:53PM +0100, Niklas Söderlund wrote:
Hi Shang,
Thanks for your work.
On 2022-12-06 21:05:55 +0800, Shang XiaoJing wrote:
There is a kmemleak when testing the media/i2c/max9286.c with bpf mock
device:
Out of curiosity, what exactly is a bpf mock device?
I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?
Yes, I'm using the tool provided by Yongjun, and now it can support for
the tests of spi drivers and i2c drivers, which is still in the
preliminary validation phase.
Is the implementation public ?
Will send the test set to the community after the further verification
to the tool.
By the way, here's an introduction to the tool, but now only in Chinese:
https://github.com/ChinaLinuxKernel/CLK2022/blob/main/%E5%9F%BA%E4%BA%8EeBPF%E7%9A%84%E8%AE%BE%E5%A4%87%E9%A9%B1%E5%8A%A8%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6.pdf
Regardless of how this has been tested, the fix looks good.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks for the review!
--
Shang XiaoJing
