Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> ________________________ BRs, VTG - Linux&Chrome IPU SW Bingbu Cao > -----Original Message----- > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Sent: Monday, December 5, 2022 23:22 > To: Rui Miguel Silva <rmfrfs@xxxxxxxxx>; Sakari Ailus > <sakari.ailus@xxxxxxxxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx>; Qiu, > Tian Shu <tian.shu.qiu@xxxxxxxxx>; Su, Jimmy <jimmy.su@xxxxxxxxx>; linux- > media@xxxxxxxxxxxxxxx > Cc: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Subject: [PATCH v2 4/5] media: i2c: imx355: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT > on flips > > The driver changes the Bayer order based on the flips, but does not define > the control correctly with the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag. > > Add the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag. > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > --- > drivers/media/i2c/imx355.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index > b46178681c05..25d4dbb6041e 100644 > --- a/drivers/media/i2c/imx355.c > +++ b/drivers/media/i2c/imx355.c > @@ -1617,8 +1617,12 @@ static int imx355_init_controls(struct imx355 *imx355) > > imx355->hflip = v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, > V4L2_CID_HFLIP, 0, 1, 1, 0); > + if (imx355->hflip) > + imx355->hflip->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT; > imx355->vflip = v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, > V4L2_CID_VFLIP, 0, 1, 1, 0); > + if (imx355->vflip) > + imx355->vflip->flags |= V4L2_CTRL_FLAG_MODIFY_LAYOUT; > > v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, V4L2_CID_ANALOGUE_GAIN, > IMX355_ANA_GAIN_MIN, IMX355_ANA_GAIN_MAX, > -- > 2.34.1
