Hi Michael, On Sat, Sep 10, 2022 at 12:13:31AM +0200, Michael Grzeschik wrote: > This series improves the uvc video gadget by parsing the configfs > entries. With the configfs data, the userspace now is able to use simple > v4l2 api calls like enum and try_format to check for valid configurations > initially set by configfs. I've realized that this whole series got merged, despite my multiple attempts to explain why I think it's not a good idea. The UVC gadget requires userspace support, and there's no point in trying to move all these things to the kernel side. It only bloats the kernel, makes the code more complex, more difficult to maintain, and will make UVC 1.5 support more difficult. I'm fairly unhappy with this, it will lower my trust towards your patches. > Michael Grzeschik (4): > media: v4l: move helper functions for fractions from uvc to > v4l2-common > media: uvcvideo: move uvc_format_desc to common header > usb: gadget: uvc: add v4l2 enumeration api calls > usb: gadget: uvc: add v4l2 try_format api call > > drivers/media/usb/uvc/uvc_ctrl.c | 1 + > drivers/media/usb/uvc/uvc_driver.c | 290 +------------------- > drivers/media/usb/uvc/uvc_v4l2.c | 14 +- > drivers/media/usb/uvc/uvcvideo.h | 147 ---------- > drivers/media/v4l2-core/v4l2-common.c | 86 ++++++ > drivers/usb/gadget/function/f_uvc.c | 30 +++ > drivers/usb/gadget/function/uvc.h | 2 + > drivers/usb/gadget/function/uvc_v4l2.c | 286 ++++++++++++++++++++ > include/media/v4l2-common.h | 4 + > include/media/v4l2-uvc.h | 359 +++++++++++++++++++++++++ > 10 files changed, 776 insertions(+), 443 deletions(-) > create mode 100644 include/media/v4l2-uvc.h -- Regards, Laurent Pinchart
