Hi! Thanks for the review. On Thu, Dec 1, 2022 at 4:16 PM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Yunke, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v6.1-rc7 next-20221201] > [cannot apply to media-tree/master] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yunke-Cao/media-Implement-UVC-v1-5-ROI/20221201-103422 > patch link: https://lore.kernel.org/r/20221201023204.2177458-3-yunkec%40google.com > patch subject: [PATCH v10 02/11 RESEND] media: uvcvideo: add uvc_ctrl_get_boundary for getting default value > config: m68k-allyesconfig > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/bb57965a09e65c4ed0cc01d63e158bba810648b4 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yunke-Cao/media-Implement-UVC-v1-5-ROI/20221201-103422 > git checkout bb57965a09e65c4ed0cc01d63e158bba810648b4 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/usb/uvc/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > drivers/media/usb/uvc/uvc_ctrl.c: In function 'uvc_ctrl_get_boundary': > >> drivers/media/usb/uvc/uvc_ctrl.c:1788:73: warning: passing argument 4 of '__uvc_ctrl_get_boundary_std' makes integer from pointer without a cast [-Wint-conversion] > 1788 | ret = __uvc_ctrl_get_boundary_std(chain, ctrl, mapping, xctrl); > | ^~~~~ > | | > | struct v4l2_ext_control * > drivers/media/usb/uvc/uvc_ctrl.c:1755:44: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'struct v4l2_ext_control *' > 1755 | u32 v4l2_which, > | ~~~~^~~~~~~~~~ 1755 | u32 v4l2_which, This parameter should have been added as part of patch 10/11 instead of here. Sorry! Will fix it in the next version. > drivers/media/usb/uvc/uvc_ctrl.c:1788:23: error: too few arguments to function '__uvc_ctrl_get_boundary_std' > 1788 | ret = __uvc_ctrl_get_boundary_std(chain, ctrl, mapping, xctrl); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/media/usb/uvc/uvc_ctrl.c:1752:12: note: declared here > 1752 | static int __uvc_ctrl_get_boundary_std(struct uvc_video_chain *chain, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +/__uvc_ctrl_get_boundary_std +1788 drivers/media/usb/uvc/uvc_ctrl.c > > 1768 > 1769 int uvc_ctrl_get_boundary(struct uvc_video_chain *chain, > 1770 struct v4l2_ext_control *xctrl) > 1771 { > 1772 struct uvc_control *ctrl; > 1773 struct uvc_control_mapping *mapping; > 1774 int ret; > 1775 > 1776 if (mutex_lock_interruptible(&chain->ctrl_mutex)) > 1777 return -ERESTARTSYS; > 1778 > 1779 ctrl = uvc_find_control(chain, xctrl->id, &mapping); > 1780 if (!ctrl) { > 1781 ret = -EINVAL; > 1782 goto done; > 1783 } > 1784 > 1785 if (uvc_ctrl_mapping_is_compound(mapping)) > 1786 ret = -EINVAL; > 1787 else > > 1788 ret = __uvc_ctrl_get_boundary_std(chain, ctrl, mapping, xctrl); > 1789 > 1790 done: > 1791 mutex_unlock(&chain->ctrl_mutex); > 1792 return ret; > 1793 } > 1794 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp
