On 30/11/2022 17:04, Milen Mitkov (Consultant) wrote:
On 30/11/2022 17:50, Bryan O'Donoghue wrote:
On 28/11/2022 14:42, quic_mmitkov@xxxxxxxxxxx wrote:
With these changes, the CSID entity has, as it did previously, a single
sink port (0), and always exposes 4 source ports (1, 2,3, 4). The
virtual channel configuration is determined by which of the source ports
are linked to an output VFE line. For example, the link below will
configure the CSID driver to enable vc 0 and vc 1:
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
media-ctl -l '"msm_csid0":2->"msm_vfe0_rdi1":0[1]'
Following your instructions here
root@linaro-gnome:~# media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
root@linaro-gnome:~# media-ctl -l '"msm_csid0":2->"msm_vfe0_rdi1":0[1]'
root@linaro-gnome:~# media-ctl -l '"msm_csid0":3->"msm_vfe0_rdi2":0[1]'
root@linaro-gnome:~# media-ctl -l '"msm_csid0":4->"msm_vfe0_rdi3":0[1]'
Unable to parse link: Invalid argument (22)
?
---
bod
Hi Bryan,
Thanks for the feedback! There are the following IFEs on SM8250 (Titan
4.8):
IFE0 -> has 3 RDI lines and 1 PIX line
IFE1 -> has 3 RDI lines and 1 PIX line
IFELite0 -> has 4 RDI lines
IFELite1 -> has 4 RDI lines
so there's no msm_vfe0_rdi3 port for IFE0 and IFE1 at all, only rdi0,
rdi1, rdi2. In theory if you link the 4th CSID source port to
msm_vfe0_pix the parsing works:
media-ctl -l '"msm_csid0":4->"msm_vfe0_pix":0[1]'
However, in practice, there's no PIX support in camss so even if the
linking works, the hardware won't get configured properly.
You can however use the IFELite's 4th RDI port. Due to omission in
camss-vfe there isn't any separate logic for naming the sink ports of
IFELite's devies so it's still called "pix", even though it's not a pix
port. It should be a small code change to fix the naming of the port for
IFELite, I could do it as part of this patch set or as a new patch after
this patch set gets merged. Which is the preferred way?
Regards,
Milen
Hmm, OK the pix mapping works for me, thanks, the
It would be good to fixup the name, maybe as an additional patch.
Also the above description contains important information. IMO its
worthwhile to include information like that in the git log.
i.e. IFE <-> RDI mapping, IFELite <-> RDI mapping
Also suggest adding example media-ctl commands for the VCs to your git
log both for yourself to remember - I'm usually logging so that I can
remind myself - but also for other people to more easily
replicate/validate your work.
---
bod
