Hi Hans
On 28/11/2022 21:44, Hans de Goede wrote:
For the regular GPIO pins the value should be read from TPS68470_REG_GPDI,
so that the actual value of the pin is read, rather then the value the pin
would output when put in output mode.
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Good spot:
Reviewed-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>
Just building the series to test it too
---
drivers/gpio/gpio-tps68470.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c
index aaddcabe9b35..778a72cf800c 100644
--- a/drivers/gpio/gpio-tps68470.c
+++ b/drivers/gpio/gpio-tps68470.c
@@ -30,7 +30,7 @@ static int tps68470_gpio_get(struct gpio_chip *gc, unsigned int offset)
{
struct tps68470_gpio_data *tps68470_gpio = gpiochip_get_data(gc);
struct regmap *regmap = tps68470_gpio->tps68470_regmap;
- unsigned int reg = TPS68470_REG_GPDO;
+ unsigned int reg = TPS68470_REG_GPDI;
int val, ret;
if (offset >= TPS68470_N_REGULAR_GPIO) {
