On Wed, Nov 30, 2022 at 1:12 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On some systems, e.g. the Lenovo ThinkPad X1 Yoga gen 7 and the ThinkPad > X1 Nano gen 2 there is no clock-enable pin, triggering the: > "No clk GPIO. The privacy LED won't work" warning and causing the privacy > LED to not work. > > Fix this by treating the privacy LED as a regular GPIO rather then > integrating it with the registered clock. > > Note this relies on the ov5693 driver change to support an (optional) > privacy-led GPIO to avoid the front cam privacy LED regressing on some > models. ... > - case INT3472_GPIO_TYPE_PRIVACY_LED: > - gpio = acpi_get_and_request_gpiod(path, pin, "int3472,privacy-led"); > - if (IS_ERR(gpio)) > - return (PTR_ERR(gpio)); > > - int3472->clock.led_gpio = gpio; > - break; I'm not sure how the previous patch makes this one work without regressions. We have a "privacy-led" GPIO name there and here it used to be with a prefix. Maybe I'm missing something... -- With Best Regards, Andy Shevchenko
