Hi Hans,
Thanks for your review,
On Fri, Nov 25, 2022 at 03:20:46PM +0100, Hans Verkuil wrote:
> On 25/11/2022 14:34, Volodymyr Kharuk wrote:
> > Define Time of Flight class controls.
> > Also add most common TOF controls:
> > - phase sequence
> > - time integration
> > - frequency modulation
> >
> > Signed-off-by: Volodymyr Kharuk <vkh@xxxxxxxxxxx>
> > ---
> > include/uapi/linux/v4l2-controls.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> > index d27e255ed33b..a9ecfaa4252c 100644
> > --- a/include/uapi/linux/v4l2-controls.h
> > +++ b/include/uapi/linux/v4l2-controls.h
> > @@ -68,6 +68,7 @@
> > #define V4L2_CTRL_CLASS_DETECT 0x00a30000 /* Detection controls */
> > #define V4L2_CTRL_CLASS_CODEC_STATELESS 0x00a40000 /* Stateless codecs controls */
> > #define V4L2_CTRL_CLASS_COLORIMETRY 0x00a50000 /* Colorimetry controls */
> > +#define V4L2_CTRL_CLASS_TOF 0x00a60000 /* Time of light camera controls */
>
> light -> flight
oh, indeed. Will fix.
>
> >
> > /* User-class control IDs */
> >
> > @@ -2782,6 +2783,13 @@ struct v4l2_ctrl_vp9_compressed_hdr {
> > struct v4l2_vp9_mv_probs mv;
> > };
> >
> > +#define V4L2_CID_TOF_CLASS_BASE (V4L2_CTRL_CLASS_TOF | 0x900)
> > +#define V4L2_CID_TOF_CLASS (V4L2_CTRL_CLASS_TOF | 1)
> > +
> > +#define V4L2_CID_TOF_PHASE_SEQ (V4L2_CID_TOF_CLASS_BASE + 0)
> > +#define V4L2_CID_TOF_FMOD (V4L2_CID_TOF_CLASS_BASE + 1)
>
> I'd go for _FREQ_MOD
Ok. Will fix.
>
> > +#define V4L2_CID_TOF_TINT (V4L2_CID_TOF_CLASS_BASE + 2)
>
> and _TIME_INTEGRATION
Ok. Will fix.
>
> Regards,
>
> Hans
>
> > +
> > /* MPEG-compression definitions kept for backwards compatibility */
> > #ifndef __KERNEL__
> > #define V4L2_CTRL_CLASS_MPEG V4L2_CTRL_CLASS_CODEC
>
--
--
BR,
Volodymyr Kharuk
