RE: [EXT] Re: [PATCH v2] media: ov5640: set correct default link frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Okay, thanks again.

> -----Original Message-----
> From: Jacopo Mondi <jacopo@xxxxxxxxxx>
> Sent: 2022年11月25日 17:02
> To: G.N. Zhou <guoniu.zhou@xxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx; slongerbeam@xxxxxxxxx;
> mchehab@xxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; hugues.fruchet@xxxxxx;
> laurent.pinchart@xxxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v2] media: ov5640: set correct default link frequency
> 
> Caution: EXT Email
> 
> Hello again
> 
> On Fri, Nov 25, 2022 at 04:48:32PM +0800, Guoniu.zhou wrote:
> > current_link_freq field in ov5640_dev structure is link frequency, not
> > link frequency array index, so correct it.
> >
> > Fixes: 3c28588f35d3 ("media: ov5640: Update pixel_rate and link_freq")
> >
> 
> The empty line might be dropped when applying the patch ?
> 
> > Signed-off-by: Guoniu.zhou <guoniu.zhou@xxxxxxx>
> 
> Please retain the tags you receive in the next version you send.
> 
> Re-adding it here:
> Acked-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> 
> Thanks
>   j
> 
> > ---
> > v2:
> >   - Correct typo issue(s/structrue/structure)
> > ---
> >  drivers/media/i2c/ov5640.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> > index 2d740397a5d4..3f6d715efa82 100644
> > --- a/drivers/media/i2c/ov5640.c
> > +++ b/drivers/media/i2c/ov5640.c
> > @@ -3817,7 +3817,8 @@ static int ov5640_probe(struct i2c_client *client)
> >       sensor->current_mode =
> >               &ov5640_mode_data[OV5640_MODE_VGA_640_480];
> >       sensor->last_mode = sensor->current_mode;
> > -     sensor->current_link_freq = OV5640_DEFAULT_LINK_FREQ;
> > +     sensor->current_link_freq =
> > +             ov5640_csi2_link_freqs[OV5640_DEFAULT_LINK_FREQ];
> >
> >       sensor->ae_target = 52;
> >
> > --
> > 2.37.1
> >




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux