From: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
-Update pixel_rate and link frequency for 1920x1080@30
Add dummy ctrl cases for pixel_rate and link frequency
to avoid error while changing the modes dynamically
Suggested-by: Sakari Ailus <sakari.ailus@xxxxxx>
Signed-off-by: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
---
drivers/media/i2c/imx334.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 0e5575604d87..ec77835d94a2 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -50,6 +50,7 @@
/* CSI2 HW configuration */
#define IMX334_LINK_FREQ 1782000000
+#define IMX334_LINK_FREQ_891M 891000000
#define IMX334_NUM_DATA_LANES 4
#define IMX334_REG_MIN 0x00
@@ -145,6 +146,7 @@ struct imx334 {
static const s64 link_freq[] = {
IMX334_LINK_FREQ,
+ IMX334_LINK_FREQ_891M,
};
/* Sensor mode registers */
@@ -471,7 +473,7 @@ static const struct imx334_mode supported_modes[] = {
.vblank_min = 90,
.vblank_max = 132840,
.pclk = 74250000,
- .link_freq_idx = 0,
+ .link_freq_idx = 1,
.reg_list = {
.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
.regs = mode_1920x1080_regs,
@@ -601,6 +603,11 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret)
return ret;
+ ret = __v4l2_ctrl_modify_range(imx334->pclk_ctrl, mode->pclk,
+ mode->pclk, 1, mode->pclk);
+ if (ret)
+ return ret;
+
ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, IMX334_REG_MIN,
IMX334_REG_MAX, 1, mode->hblank);
if (ret)
@@ -700,6 +707,10 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
pm_runtime_put(imx334->dev);
+ break;
+ case V4L2_CID_PIXEL_RATE:
+ case V4L2_CID_LINK_FREQ:
+ ret = 0;
break;
default:
dev_err(imx334->dev, "Invalid control %d", ctrl->id);
--
2.34.1
