Hi Zev,
On 2022/11/23 上午 07:12, Zev Weiss wrote:
On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote:
If the host is powered off, there will be many warning log. To avoid the
log spam in this condition, replace v4l2_warn with v4l2_dbg.
Signed-off-by: Jammy Huang <jammy_huang@xxxxxxxxxxxxxx>
---
drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
Thanks Jammy -- after dropping the one hunk that wasn't applicable (due
to not having all the prerequisite patches) this definitely fixed the
log noise problems I'd been having.
I'm assuming the prerequisite patches are from your aspeed-jpeg support
patch series? If so, since this is a smaller/simpler patch, I think it
might make sense to reorder things to try to get this merged first and
then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(),
rather than introducing a new instance of it and then patching it back
out later with this one.
Yes, the prerequisite patches are 'aspeed-jpeg support' patch series.
And that patch series
has been accepted and pull for v6.2. Your suggestion is better to
decouple these patches.
I would pay attention to the problem like this to avoid this condition
in the future.
Many thanks for your kindly help.
Thanks,
Zev
--
Best Regards
Jammy
