Hi Yuji, On 10/08/2022 15:28, Yuji Ishikawa wrote: > This series is the Video Input Interface driver > for Toshiba's ARM SoC, Visconti[0]. > This provides DT binding documentation, > device driver, documentation and MAINTAINER files. > > A visconti VIIF driver instance exposes > 1 media control device file and 3 video device files > for a VIIF hardware. > Detailed HW/SW are described in documentation directory. > The VIIF hardware has CSI2 receiver, > image signal processor and DMAC inside. > The subdevice for image signal processor provides > vendor specific V4L2 controls. > > The device driver depends on two other drivers under development; > clock framework driver and IOMMU driver. > Corresponding features will be added later. I'm not sure what the status is of this series. There were comments for patch 1, and also note that patch 2 never made it to the linux-media mailinglist (too large, it should be split up in smaller patches). I'm marking it as 'Changes Requested' in patchwork, so please post a v4 and I will do my best to review it. Also please ping me in the future to encourage me to review it. These are big drivers and it takes a lot of time to review, so I have a tendency (wrong, I know) keep postponing it. A ping helps me prioritize it. Regards, Hans > > Best regards, > Yuji > > Changelog v2: > - Resend v1 because a patch exceeds size limit. > > Changelog v3: > - Add documentation to describe SW and HW > - Adapted to media control framework > - Introduced ISP subdevice, capture device > - Remove private IOCTLs and add vendor specific V4L2 controls > - Change function name avoiding camelcase and uppercase letters > > [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html > > Yuji Ishikawa (4): > dt-bindings: media: platform: visconti: Add Toshiba Visconti Video > Input Interface bindings > media: platform: visconti: Add Toshiba Visconti Video Input Interface > driver > documentation: media: add documentation for Toshiba Visconti Video > Input Interface driver > MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface > > .../bindings/media/toshiba,visconti-viif.yaml | 103 + > .../driver-api/media/drivers/index.rst | 1 + > .../media/drivers/visconti-viif.rst | 455 +++ > MAINTAINERS | 3 + > drivers/media/platform/Kconfig | 2 + > drivers/media/platform/Makefile | 4 + > drivers/media/platform/visconti/Kconfig | 9 + > drivers/media/platform/visconti/Makefile | 9 + > drivers/media/platform/visconti/hwd_viif.c | 1791 +++++++++++ > drivers/media/platform/visconti/hwd_viif.h | 701 +++++ > .../media/platform/visconti/hwd_viif_csi2rx.c | 723 +++++ > .../platform/visconti/hwd_viif_internal.h | 348 ++ > .../media/platform/visconti/hwd_viif_l1isp.c | 2727 ++++++++++++++++ > .../media/platform/visconti/hwd_viif_reg.h | 2802 +++++++++++++++++ > drivers/media/platform/visconti/viif.c | 479 +++ > drivers/media/platform/visconti/viif.h | 195 ++ > .../media/platform/visconti/viif_capture.c | 1215 +++++++ > .../media/platform/visconti/viif_controls.c | 1149 +++++++ > drivers/media/platform/visconti/viif_isp.c | 852 +++++ > include/uapi/linux/visconti_viif.h | 1724 ++++++++++ > 20 files changed, 15292 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > create mode 100644 Documentation/driver-api/media/drivers/visconti-viif.rst > create mode 100644 drivers/media/platform/visconti/Kconfig > create mode 100644 drivers/media/platform/visconti/Makefile > create mode 100644 drivers/media/platform/visconti/hwd_viif.c > create mode 100644 drivers/media/platform/visconti/hwd_viif.h > create mode 100644 drivers/media/platform/visconti/hwd_viif_csi2rx.c > create mode 100644 drivers/media/platform/visconti/hwd_viif_internal.h > create mode 100644 drivers/media/platform/visconti/hwd_viif_l1isp.c > create mode 100644 drivers/media/platform/visconti/hwd_viif_reg.h > create mode 100644 drivers/media/platform/visconti/viif.c > create mode 100644 drivers/media/platform/visconti/viif.h > create mode 100644 drivers/media/platform/visconti/viif_capture.c > create mode 100644 drivers/media/platform/visconti/viif_controls.c > create mode 100644 drivers/media/platform/visconti/viif_isp.c > create mode 100644 include/uapi/linux/visconti_viif.h >
