Hi Laurent On Tue, 22 Nov 2022 at 22:34, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > There's no need to configure the data lanes in the runtime PM resume > handler. Do so in imx290_start_streaming() instead. Interesting as I had Sakari advocating putting clock mode selection register control in "power on" for my recent ov9282 series. Is there any consistency? Dave https://patchwork.linuxtv.org/project/linux-media/patch/20221005152809.3785786-9-dave.stevenson@xxxxxxxxxxxxxxx/#141118 > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/imx290.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index dbed703fa199..4dfa090f918d 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -753,6 +753,9 @@ static int imx290_start_streaming(struct imx290 *imx290, > return ret; > } > > + /* Set data lane count */ > + imx290_set_data_lanes(imx290); > + > /* Apply the register values related to current frame format */ > format = v4l2_subdev_get_pad_format(&imx290->sd, state, 0); > ret = imx290_setup_format(imx290, format); > @@ -1052,9 +1055,6 @@ static int imx290_power_on(struct device *dev) > gpiod_set_value_cansleep(imx290->rst_gpio, 0); > usleep_range(30000, 31000); > > - /* Set data lane count */ > - imx290_set_data_lanes(imx290); > - > return 0; > } > > -- > Regards, > > Laurent Pinchart >
