Hi Umang and Dave, Thank you for the patch. On Tue, Nov 22, 2022 at 03:17:10AM +0530, Umang Jain wrote: > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > Following the same pattern as bcm2835-camera and bcm2835-audio, > register the vcsm-cma driver as a platform driver. > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index dc33490ba7fb..642fdbc0d654 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -67,6 +67,7 @@ struct vchiq_state g_state; > > static struct platform_device *bcm2835_camera; > static struct platform_device *bcm2835_audio; > +static struct platform_device *vcsm_cma; > > struct vchiq_drvdata { > const unsigned int cache_line_size; > @@ -1832,6 +1833,7 @@ static int vchiq_probe(struct platform_device *pdev) > goto error_exit; > } > > + vcsm_cma = vchiq_register_child(pdev, "vcsm-cma"); > bcm2835_camera = vchiq_register_child(pdev, "bcm2835-camera"); > bcm2835_audio = vchiq_register_child(pdev, "bcm2835_audio"); > > @@ -1847,6 +1849,7 @@ static int vchiq_remove(struct platform_device *pdev) > { > platform_device_unregister(bcm2835_audio); > platform_device_unregister(bcm2835_camera); > + platform_device_unregister(vcsm_cma); > vchiq_debugfs_deinit(); > vchiq_deregister_chrdev(); > -- Regards, Laurent Pinchart