On Sun, Nov 20, 2022 at 11:40:46PM +0100, Hans de Goede wrote: > I managed to trigger an atomisp_css_start() error by pushing my test > system towards an OOM situation, this resulted in the following errors: > > atomisp-isp2 0000:00:03.0: alloc pages err... > atomisp-isp2 0000:00:03.0: hmm_bo_alloc_pages failed. > atomisp-isp2 0000:00:03.0: stream[0] start error. > > But it is not entirely clear what the root cause of > the "alloc pages err..." error is. I suspect the root cause is > alloc_pages_bulk_array() failing. Add a log message to make > the root cause more clear if this is hit again. ... > + dev_err(atomisp_dev, "alloc_pages_bulk_array() failed\n"); I would put it after calling the below function, but I'm not sure about side effects (if the below can hang or something else). > free_pages_bulk_array(ret, bo->pages); > return -ENOMEM; -- With Best Regards, Andy Shevchenko