Hi, On 11/14/22 11:38, Andy Shevchenko wrote: > On Thu, Oct 20, 2022 at 09:55:20PM +0200, Hans de Goede wrote: >> There is no guarantee that when we stop the pipeline all buffers owned >> by the CSS are cleanly returned to the videobuf queue. >> >> This is a problem with videobuf2 which will complain loudly when not >> all buffers have been returned after the streamoff() queue op has >> returned. >> >> And this also allows moving a WARN() in the continuous mode path. > > ... > >> + if (ret <= 0) >> + return ret ? ret : -ETIME; > > You can use Elvis and ETIME is not correct AFAIU, should be -ETIMEDOUT. Both fixed in the version which I'm about to push to: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp Regards, Hans
