> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 09 November 2022 14:43 > To: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; > mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx; > benjamin.gaignard@xxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > stanimir.varbanov@xxxxxxxxxx; dillon.minfei@xxxxxxxxx; > david.plowman@xxxxxxxxxxxxxxx; mark.rutland@xxxxxxx; > robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; andi@xxxxxxxxxxx; > alim.akhtar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; smitha.t@xxxxxxxxxxx > Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for > Exynos3250 SoC. > > On 09/11/2022 04:55, Aakarsh Jain wrote: > > Since,MFC v7 support was added for Exynos5420 and Exynos > > 3250 SoC with same compatible string "samsung,mfc-v7".As both SoCs > > having different hardware properties and having same compatible string > > for both SoCs doesn't seems to be correct. > > New compatible is added for Exynos3250 SOC which will differentiate > > the node properties for both SoCs which support MFC v7. > > > > Reviewed-by: Tommaso Merciai > <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx> > > Suggested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > > Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > Beside my previous comment, please include changelog. This is v2, right? > Yes this is v2. I have sent v3 along with cover letter. > You should consider joining something like: > https://protect2.fireeye.com/v1/url?k=bf47b121-dfa52c7c-bf463a6e- > 000babd9f1ba-202e284cd3057a5d&q=1&e=009abfcf-7d3c-433c-8eea- > 0f9d92caf6cc&u=https%3A%2F%2Fwww.linaro.org%2Fevents%2Fmember- > training-upstream-kernel-development%2F > > Best regards, > Krzysztof Thanks for review.
