Hi Sakari, On 22-11-07, Sakari Ailus wrote: > Hi Marco, > > On Thu, Nov 03, 2022 at 06:30:16PM +0100, Marco Felsch wrote: > > Hi, > > > > On 22-11-03, kernel test robot wrote: > > > tree: git://linuxtv.org/sailus/media_tree.git master > > > head: 7336c54a562b479866d2de2abc61487a4e07b0b9 > > > commit: 80a21da360516fa602f3a50eb9792f9dfbfb5fdb [43/47] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver > > > config: sh-allmodconfig > > > compiler: sh4-linux-gcc (GCC) 12.1.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > git remote add sailus-media-tree git://linuxtv.org/sailus/media_tree.git > > > git fetch --no-tags sailus-media-tree master > > > git checkout 80a21da360516fa602f3a50eb9792f9dfbfb5fdb > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/ > > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > > > All errors (new ones prefixed by >>): > > > > > > >> drivers/clk/clk.c:941:6: error: redefinition of 'clk_unprepare' > > > 941 | void clk_unprepare(struct clk *clk) > > > | ^~~~~~~~~~~~~ > > > In file included from drivers/clk/clk.c:9: > > > include/linux/clk.h:303:20: note: previous definition of 'clk_unprepare' with type 'void(struct clk *)' > > > 303 | static inline void clk_unprepare(struct clk *clk) > > > | ^~~~~~~~~~~~~ > > > >> drivers/clk/clk.c:1022:5: error: redefinition of 'clk_prepare' > > > 1022 | int clk_prepare(struct clk *clk) > > > | ^~~~~~~~~~~ > > > include/linux/clk.h:271:19: note: previous definition of 'clk_prepare' with type 'int(struct clk *)' > > > 271 | static inline int clk_prepare(struct clk *clk) > > > | ^~~~~~~~~~~ > > > >> drivers/clk/clk.c:1268:6: error: redefinition of 'clk_is_enabled_when_prepared' > > > 1268 | bool clk_is_enabled_when_prepared(struct clk *clk) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > include/linux/clk.h:284:20: note: previous definition of 'clk_is_enabled_when_prepared' with type 'bool(struct clk *)' {aka '_Bool(struct clk *)'} > > > 284 | static inline bool clk_is_enabled_when_prepared(struct clk *clk) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Kconfig warnings: (for reference only) > > > WARNING: unmet direct dependencies detected for COMMON_CLK > > > Depends on [n]: !HAVE_LEGACY_CLK [=y] > > > Selected by [m]: > > > - VIDEO_TC358746 [=m] && MEDIA_SUPPORT [=m] && VIDEO_DEV [=m] && PM [=y] && I2C [=m] > > > > Hm.. this is strange but my relate to the unmet dependency. I could add > > a depends on COMMON_CLK but this no i2c driver is doing that, just a few > > platform drivers. > > I think you should drop the dependency (through select) altogether as you > (I expect) don't really need the common clock framework. > > Could you send a patch? I will send a patch which drops the select. Regards, Marco
