On Fri, 2022-11-04 at 12:54 +0100, Hans Verkuil wrote: > On 07/10/2022 11:22, Moudy Ho wrote: > > Due to future support for hardware compression formats, the MDP3 > > internal color format expression needs to be extended. > > > > Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx> > > --- > > .../platform/mediatek/mdp3/mtk-mdp3-regs.h | 193 +++++++++----- > > ---- > > 1 file changed, 97 insertions(+), 96 deletions(-) > > > > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h > > b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h > > index 1a26c1bcfd8d..439f72dc1ff5 100644 > > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h > > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-regs.h > > @@ -18,11 +18,12 @@ > > * V-subsample: 0, 1 > > * Color group: 0-RGB, 1-YUV, 2-raw > > */ (snip) > > > > /* Packed 10-bit formats */ > > - MDP_COLOR_RGBA1010102 = MDP_COLOR(1, 0, 0, 1, 0, 0, > > 32, 0, 1, 2), > > - MDP_COLOR_BGRA1010102 = MDP_COLOR(1, 0, 0, 1, 0, 0, > > 32, 0, 0, 2), > > + MDP_COLOR_RGBA1010102 = MDP_COLOR(0, 1, 0, 0, 1, 0, 0, > > 32, 0, 1, 2), > > + MDP_COLOR_BGRA1010102 = MDP_COLOR(0, 1, 0, 0, 1, 0, 0, > > 32, 0, 0, 2), > > /* Packed 10-bit UYVY */ > > MDP_COLOR_UYVY_10P = MDP_COLOR(1, 0, 0, 1, 1, 0, 20, 1, 0, > > 4), > > You missed this one, it needs an additional argument. I guess you > didn't compile this? > > Regards, > > Hans > Hi Hans, Thanks for the reminder, this error has been fixed at v2 and the latest v3. https://patchwork.kernel.org/project/linux-mediatek/patch/20221103064842.12042-8-moudy.ho@xxxxxxxxxxxx/ Sincerely, Moudy Ho > > /* Packed 10-bit NV21 */ > > - MDP_COLOR_NV21_10P = MDP_COLOR(1, 0, 0, 2, 1, 1, 10, 1, 1, > > 12), > > + MDP_COLOR_NV21_10P = MDP_COLOR(0, 1, 0, 0, 2, 1, 1, 10, 1, 1, > > 12), > > /* 10-bit block mode */ > > - MDP_COLOR_420_BLK_10_H = MDP_COLOR(1, 0, 1, 2, 1, 1, 320, > > 1, 0, 12), > > + MDP_COLOR_420_BLK_10_H = MDP_COLOR(0, 1, 0, 1, 2, 1, 1, > > 320, 1, 0, 12), > > /* 10-bit HEVC tile mode */ > > - MDP_COLOR_420_BLK_10_V = MDP_COLOR(1, 1, 1, 2, 1, 1, 320, > > 1, 0, 12), > > + MDP_COLOR_420_BLK_10_V = MDP_COLOR(0, 1, 1, 1, 2, 1, 1, > > 320, 1, 0, 12), > > /* UFO encoded 10-bit block mode */ > > - MDP_COLOR_420_BLK_U10_H = MDP_COLOR(1, 0, 5, 2, 1, 1, 320, > > 1, 0, 12), > > + MDP_COLOR_420_BLK_U10_H = MDP_COLOR(0, 1, 0, 5, 2, 1, 1, > > 320, 1, 0, 12), > > /* UFO encoded 10-bit HEVC tile mode */ > > - MDP_COLOR_420_BLK_U10_V = MDP_COLOR(1, 1, 5, 2, 1, 1, 320, > > 1, 0, 12), > > + MDP_COLOR_420_BLK_U10_V = MDP_COLOR(0, 1, 1, 5, 2, 1, 1, > > 320, 1, 0, 12), > > > > /* Loose 10-bit formats */ > > - MDP_COLOR_UYVY_10L = MDP_COLOR(0, 1, 0, 1, 1, 0, 20, 1, 0, > > 4), > > - MDP_COLOR_VYUY_10L = MDP_COLOR(0, 1, 0, 1, 1, 0, 20, 1, 1, > > 4), > > - MDP_COLOR_YUYV_10L = MDP_COLOR(0, 1, 0, 1, 1, 0, 20, 1, 0, > > 5), > > - MDP_COLOR_YVYU_10L = MDP_COLOR(0, 1, 0, 1, 1, 0, 20, 1, 1, > > 5), > > - MDP_COLOR_NV12_10L = MDP_COLOR(0, 1, 0, 2, 1, 1, 10, 1, 0, > > 12), > > - MDP_COLOR_NV21_10L = MDP_COLOR(0, 1, 0, 2, 1, 1, 10, 1, 1, > > 12), > > - MDP_COLOR_NV16_10L = MDP_COLOR(0, 1, 0, 2, 1, 0, 10, 1, 0, > > 13), > > - MDP_COLOR_NV61_10L = MDP_COLOR(0, 1, 0, 2, 1, 0, 10, 1, 1, > > 13), > > - MDP_COLOR_YV12_10L = MDP_COLOR(0, 1, 0, 3, 1, 1, 10, 1, 1, > > 8), > > - MDP_COLOR_I420_10L = MDP_COLOR(0, 1, 0, 3, 1, 1, 10, 1, 0, > > 8), > > + MDP_COLOR_UYVY_10L = MDP_COLOR(0, 0, 1, 0, 1, 1, 0, 20, 1, 0, > > 4), > > + MDP_COLOR_VYUY_10L = MDP_COLOR(0, 0, 1, 0, 1, 1, 0, 20, 1, 1, > > 4), > > + MDP_COLOR_YUYV_10L = MDP_COLOR(0, 0, 1, 0, 1, 1, 0, 20, 1, 0, > > 5), > > + MDP_COLOR_YVYU_10L = MDP_COLOR(0, 0, 1, 0, 1, 1, 0, 20, 1, 1, > > 5), > > + MDP_COLOR_NV12_10L = MDP_COLOR(0, 0, 1, 0, 2, 1, 1, 16, 1, 0, > > 12), > > + MDP_COLOR_NV21_10L = MDP_COLOR(0, 0, 1, 0, 2, 1, 1, 16, 1, 1, > > 12), > > + MDP_COLOR_NV16_10L = MDP_COLOR(0, 0, 1, 0, 2, 1, 0, 16, 1, 0, > > 13), > > + MDP_COLOR_NV61_10L = MDP_COLOR(0, 0, 1, 0, 2, 1, 0, 16, 1, 1, > > 13), > > + MDP_COLOR_YV12_10L = MDP_COLOR(0, 0, 1, 0, 3, 1, 1, 16, 1, 1, > > 8), > > + MDP_COLOR_I420_10L = MDP_COLOR(0, 0, 1, 0, 3, 1, 1, 16, 1, 0, > > 8), > > }; > > > > static inline bool MDP_COLOR_IS_UV_COPLANE(enum mdp_color c) > >
