Hi Aakarsh,
On Wed, Nov 02, 2022 at 06:36:01PM +0530, Aakarsh Jain wrote:
> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
> Exynos3250 and used the same compatible string as used by
> Exynos5240 but both the IPs are a bit different in terms of
> IP clock.
> Lets add variant driver data based on the new compatible string
> "samsung,exynos3250-mfc" for Exynos3250 SoC.
>
> Suggested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Fixes: 5441e9dafdfc ("[media] s5p-mfc: Core support for MFC v7")
> Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>
> ---
> .../media/platform/samsung/s5p-mfc/s5p_mfc.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> index fca5c6405eec..007c7dbee037 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
> @@ -1576,8 +1576,18 @@ static struct s5p_mfc_variant mfc_drvdata_v7 = {
> .port_num = MFC_NUM_PORTS_V7,
> .buf_size = &buf_size_v7,
> .fw_name[0] = "s5p-mfc-v7.fw",
> - .clk_names = {"mfc", "sclk_mfc"},
> - .num_clocks = 2,
> + .clk_names = {"mfc"},
> + .num_clocks = 1,
> +};
> +
> +static struct s5p_mfc_variant mfc_drvdata_v7_3250 = {
> + .version = MFC_VERSION_V7,
> + .version_bit = MFC_V7_BIT,
> + .port_num = MFC_NUM_PORTS_V7,
> + .buf_size = &buf_size_v7,
> + .fw_name[0] = "s5p-mfc-v7.fw",
> + .clk_names = {"mfc", "sclk_mfc"},
> + .num_clocks = 2,
> };
>
> static struct s5p_mfc_buf_size_v6 mfc_buf_size_v8 = {
> @@ -1647,6 +1657,9 @@ static const struct of_device_id exynos_mfc_match[] = {
> }, {
> .compatible = "samsung,mfc-v7",
> .data = &mfc_drvdata_v7,
> + }, {
> + .compatible = "samsung,exynos3250-mfc",
> + .data = &mfc_drvdata_v7_3250,
> }, {
> .compatible = "samsung,mfc-v8",
> .data = &mfc_drvdata_v8,
> --
> 2.17.1
>
Patch looks good to me, only one fix in commit body:
"... Exynos3250 and used the same compatible string..."
with:
"... Exynos3250 and use the same compatible string...
But this is a nitpicking :)
Regards,
Tommaso
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@xxxxxxxxxxxxxxxxxxxx
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@xxxxxxxxxxxxxxxxxxxx
www.amarulasolutions.com
