Hi Dave
On Fri, Oct 28, 2022 at 05:08:53PM +0100, Dave Stevenson wrote:
> The configured vblank_min setting of 151 (meaning VTS of
> 720 + 151 = 871) is far higher than the setting that works on
> the sensor, and there are no obvious restrictions stated in the
> datasheet.
>
> Reduce the vblank_min to allow for faster frame rates.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
Let's hope this work on all platforms... I wonder if when something is
not documented but experimentally confirmed we should not record it
with a comment.
That's a general issue, not on this patch specifically
Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
> drivers/media/i2c/ov9282.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 7e0b12b89655..35bc2b0438bc 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -262,7 +262,7 @@ static const struct ov9282_mode supported_modes[] = {
> .height = 720,
> .hblank = 250,
> .vblank = 1022,
> - .vblank_min = 151,
> + .vblank_min = 41,
> .vblank_max = 51540,
> .link_freq_idx = 0,
> .reg_list = {
> --
> 2.34.1
>
