Hello. On Thu, 2010-08-12 at 14:10 +0200, ext pramodh ag wrote: > Matti, > > > +/** > > + * wl1273_fm_set_tx_power() - Set the transmission power value. > > + * @core: A pointer to the device struct. > > + * @power: The new power value. > > + */ > > +static int wl1273_fm_set_tx_power(struct wl1273_core *core, u16 power) > > +{ > > + int r; > > + > > + if (core->mode == WL1273_MODE_OFF || > > + core->mode == WL1273_MODE_SUSPENDED) > > + return -EPERM; > > + > > + mutex_lock(&core->lock); > > + > > + r = wl1273_fm_write_cmd(core, WL1273_POWER_LEV_SET, power); > > Output power level is specified in units of dBuV (as explained at > http://www.linuxtv.org/downloads/v4l-dvb-apis/ch01s09.html#fm-tx-controls). > Shouldn't it be converted to WL1273 specific power level value? > > My understanding: > If output power level specified using "V4L2_CID_TUNE_POWER_LEVEL" is 122 > (dB/uV), then > power level value to be passed for WL1273 should be '0'. > Please correct me, if I got this conversion wrong. Thank you for pointing that out. I'll check and fix it... Regards, Matti > Thanks and regards, > Pramodh > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html