Hi Colin,
On Mon, Oct 24, 2022 at 03:29:54PM +0100, Colin Ian King wrote:
> Variable n is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it. This allows the for-loop to be replaced with a
> while-loop.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/media/dvb-core/dvb_demux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-core/dvb_demux.c b/drivers/media/dvb-core/dvb_demux.c
> index 83cc32ad7e12..398c86279b5b 100644
> --- a/drivers/media/dvb-core/dvb_demux.c
> +++ b/drivers/media/dvb-core/dvb_demux.c
> @@ -233,7 +233,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,
> {
> struct dvb_demux *demux = feed->demux;
> struct dmx_section_feed *sec = &feed->feed.sec;
> - u16 limit, seclen, n;
> + u16 limit, seclen;
>
> if (sec->tsfeedp >= DMX_MAX_SECFEED_SIZE)
> return 0;
> @@ -262,7 +262,7 @@ static int dvb_dmx_swfilter_section_copy_dump(struct dvb_demux_feed *feed,
> /* to be sure always set secbuf */
> sec->secbuf = sec->secbuf_base + sec->secbufp;
>
> - for (n = 0; sec->secbufp + 2 < limit; n++) {
> + while (sec->secbufp + 2 < limit) {
> seclen = section_length(sec->secbuf);
> if (seclen <= 0 || seclen > DMX_MAX_SECTION_SIZE
> || seclen + sec->secbufp > limit)
> --
> 2.37.3
>
Looks good to me.
We save some space into function stack :)
Reviewed-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx>
Regards,
Tommaso
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@xxxxxxxxxxxxxxxxxxxx
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@xxxxxxxxxxxxxxxxxxxx
www.amarulasolutions.com
