On Tue, Oct 25, 2022 at 04:58:56PM +0200, Ricardo Ribalda wrote: > On Tue, 25 Oct 2022 at 07:40, Pedro Guilherme Siqueira Moreira wrote: > > > > Change symbolic permissions to octal equivalents as recommended by > > scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c. > > > > Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@xxxxxxxxxxxxxxx> > > Reviewed-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> And for this one too: Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > drivers/media/usb/uvc/uvc_driver.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > index 7b6c97ad3a41..c5adad4e51e2 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -2362,17 +2362,17 @@ static int uvc_clock_param_set(const char *val, const struct kernel_param *kp) > > } > > > > module_param_call(clock, uvc_clock_param_set, uvc_clock_param_get, > > - &uvc_clock_param, S_IRUGO|S_IWUSR); > > + &uvc_clock_param, 0644); > > MODULE_PARM_DESC(clock, "Video buffers timestamp clock"); > > -module_param_named(hwtimestamps, uvc_hw_timestamps_param, uint, S_IRUGO|S_IWUSR); > > +module_param_named(hwtimestamps, uvc_hw_timestamps_param, uint, 0644); > > MODULE_PARM_DESC(hwtimestamps, "Use hardware timestamps"); > > -module_param_named(nodrop, uvc_no_drop_param, uint, S_IRUGO|S_IWUSR); > > +module_param_named(nodrop, uvc_no_drop_param, uint, 0644); > > MODULE_PARM_DESC(nodrop, "Don't drop incomplete frames"); > > -module_param_named(quirks, uvc_quirks_param, uint, S_IRUGO|S_IWUSR); > > +module_param_named(quirks, uvc_quirks_param, uint, 0644); > > MODULE_PARM_DESC(quirks, "Forced device quirks"); > > -module_param_named(trace, uvc_dbg_param, uint, S_IRUGO|S_IWUSR); > > +module_param_named(trace, uvc_dbg_param, uint, 0644); > > MODULE_PARM_DESC(trace, "Trace level bitmask"); > > -module_param_named(timeout, uvc_timeout_param, uint, S_IRUGO|S_IWUSR); > > +module_param_named(timeout, uvc_timeout_param, uint, 0644); > > MODULE_PARM_DESC(timeout, "Streaming control requests timeout"); > > > > /* ------------------------------------------------------------------------ -- Regards, Laurent Pinchart
