Re: [PATCH 1/5] mx2_camera: change to register and probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guennadi,

On Thu, Aug 05, 2010 at 10:17:11PM +0200, Guennadi Liakhovetski wrote:
> On Tue, 3 Aug 2010, Michael Grzeschik wrote:
> 
> > change this driver back to register and probe, since some platforms
> > first have to initialize an already registered power regulator to switch
> > on the camera.
> 
> I shall be preparing a pull-request for 2.6.36-rc1 #2, but since we 
> haven't finished discussing this and when this is ready, this will be a 
> fix - without this your platform doesn't work, right? So, we can push it 
> after rc1.

The issue is, that we cannot change the platform code from the
late_initcall structure. For me there is no other solution than that,
because we have to enable the regulator before the camera chip to
communicate over i2c. If we would move to the notify way we would
first listen for the i2c enabled clients but for that we would still
have to first enable the regulator. At this moment i don't see a
solution in this way.

The safest way would still be to use the patch as is.

Thanks,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux