Re: [PATCH v2 7/7] media: nxp: Add i.MX8 ISI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adam,

On Mon, Oct 10, 2022 at 07:27:14AM -0500, Adam Ford wrote:
> On Mon, Jul 11, 2022 at 7:06 PM Laurent Pinchart wrote:
> >
> > The Image Sensing Interface (ISI) combines image processing pipelines
> > with DMA engines to process and capture frames originating from a
> > variety of sources. The inputs to the ISI go through Pixel Link
> > interfaces, and their number and nature is SoC-dependent. They cover
> > both capture interfaces (MIPI CSI-2 RX, HDMI RX) and memory inputs.
> >
> > Signed-off-by: Christian Hemp <c.hemp@xxxxxxxxx>
> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > Signed-off-by: Guoniu Zhou <guoniu.zhou@xxxxxxx>
> > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>
> 
> I did some testing on the imx8m Nano using the code from Laurent's git
> repo as a starting point using an OV5640 camera.  I was able to
> capture an image, but there is a solid green line at the top of the
> image.  I am attaching a screenshot of my ceiling fan.  It's a little
> blurry since it was spinning, but I have taken other images and this
> green line remains. It's unclear to me if it's a camera issue, CSIS
> issue or an ISI issue, but I was curious to know if anyone has seen
> this on an imx8m Plus?
> 
> I'm going to try to run a similar test on an imx8m Mini when I get
> some more time.  I don't recall seeing this before, but I know there
> have been some updates to the OV5640 and CSIS drivers.  The same
> camera works on the Mini, but it has a different capture part, but I
> think the CSIS is the same, so I'm hoping it might narrow the issue
> down to ISI or not.

Could you provide the same image in PNG format ? The lossless
compression of JPEG creates artifacts that make it difficult to see what
should be attributed to capture issues and what is caused by the
compression.

> > ---
> >  MAINTAINERS                                   |    7 +
> >  drivers/media/platform/nxp/Kconfig            |    2 +
> >  drivers/media/platform/nxp/Makefile           |    1 +
> >  drivers/media/platform/nxp/imx8-isi/Kconfig   |   22 +
> >  drivers/media/platform/nxp/imx8-isi/Makefile  |    9 +
> >  .../platform/nxp/imx8-isi/imx8-isi-core.c     |  646 +++++++
> >  .../platform/nxp/imx8-isi/imx8-isi-core.h     |  394 +++++
> >  .../platform/nxp/imx8-isi/imx8-isi-crossbar.c |  529 ++++++
> >  .../platform/nxp/imx8-isi/imx8-isi-debug.c    |  109 ++
> >  .../media/platform/nxp/imx8-isi/imx8-isi-hw.c |  651 +++++++
> >  .../platform/nxp/imx8-isi/imx8-isi-m2m.c      |  858 ++++++++++
> >  .../platform/nxp/imx8-isi/imx8-isi-pipe.c     |  867 ++++++++++
> >  .../platform/nxp/imx8-isi/imx8-isi-regs.h     |  418 +++++
> >  .../platform/nxp/imx8-isi/imx8-isi-video.c    | 1513 +++++++++++++++++
> >  14 files changed, 6026 insertions(+)
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/Kconfig
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/Makefile
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-m2m.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h
> >  create mode 100644 drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1fc9ead83d2a..02327b4d8c9f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14270,6 +14270,13 @@ F:     Documentation/devicetree/bindings/clock/imx*
> >  F:     drivers/clk/imx/
> >  F:     include/dt-bindings/clock/imx*
> >
> > +NXP i.MX 8M ISI DRIVER
> > +M:     Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > +L:     linux-media@xxxxxxxxxxxxxxx
> > +S:     Maintained
> > +F:     Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> > +F:     drivers/media/platform/nxp/imx8-isi/
> > +
> >  NXP i.MX 8MQ DCSS DRIVER
> >  M:     Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>
> >  R:     Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
> > index 1ac0a6e91111..0f5f8976ae78 100644
> > --- a/drivers/media/platform/nxp/Kconfig
> > +++ b/drivers/media/platform/nxp/Kconfig
> > @@ -27,6 +27,8 @@ config VIDEO_VIU
> >           Say Y here if you want to enable VIU device on MPC5121e Rev2+.
> >           In doubt, say N.
> >
> 
> <snip>

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux