Hi Laurent, Thank you for your review. On 10/6/22 23:26, Laurent Pinchart wrote: > Hi Benjamin, > > Thank you for the patch. > > On Tue, Sep 27, 2022 at 10:36:59AM +0200, Benjamin Mugnier wrote: >> This extends the greyscale media bus family originally from >> MEDIA_BUS_FMT_Y8_1X8 up to MEDIA_BUS_FMT_Y14_1X14 by adding >> MEDIA_BUS_FMT_Y16_1X16, and behaves the same way with 16 bits. >> Add its documentation in subdev-formats.rst >> >> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx> >> --- >> .../media/v4l/subdev-formats.rst | 37 +++++++++++++++++++ >> include/uapi/linux/media-bus-format.h | 3 +- >> 2 files changed, 39 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst >> index d21d532eee15..19025e9ba447 100644 >> --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst >> +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst >> @@ -7355,6 +7355,43 @@ the following codes. >> - v\ :sub:`2` >> - v\ :sub:`1` >> - v\ :sub:`0` >> + * .. _MEDIA-BUS-FMT-Y16-1X16: >> + >> + - MEDIA_BUS_FMT_Y16_1X16 >> + - 0x202e >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - >> + - y\ :sub:`15` >> + - y\ :sub:`14` >> + - y\ :sub:`13` >> + - y\ :sub:`12` >> + - y\ :sub:`11` >> + - y\ :sub:`10` >> + - y\ :sub:`9` >> + - y\ :sub:`8` >> + - y\ :sub:`7` >> + - y\ :sub:`6` >> + - y\ :sub:`5` >> + - y\ :sub:`4` >> + - y\ :sub:`3` >> + - y\ :sub:`2` >> + - y\ :sub:`1` >> + - y\ :sub:`0` > > Could you please add this right after MEDIA_BUS_FMT_Y14_1X14 ? Same in include/uapi/linux/media-bus-format.h. With this change, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Sure no problem. Regards, Benjamin >> >> >> .. raw:: latex >> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h >> index ec3323dbb927..b078dd125e57 100644 >> --- a/include/uapi/linux/media-bus-format.h >> +++ b/include/uapi/linux/media-bus-format.h >> @@ -69,7 +69,7 @@ >> #define MEDIA_BUS_FMT_RGB121212_1X36 0x1019 >> #define MEDIA_BUS_FMT_RGB161616_1X48 0x101a >> >> -/* YUV (including grey) - next is 0x202e */ >> +/* YUV (including grey) - next is 0x202f */ >> #define MEDIA_BUS_FMT_Y8_1X8 0x2001 >> #define MEDIA_BUS_FMT_UV8_1X8 0x2015 >> #define MEDIA_BUS_FMT_UYVY8_1_5X8 0x2002 >> @@ -115,6 +115,7 @@ >> #define MEDIA_BUS_FMT_YUV12_1X36 0x2029 >> #define MEDIA_BUS_FMT_YUV16_1X48 0x202a >> #define MEDIA_BUS_FMT_UYYVYY16_0_5X48 0x202b >> +#define MEDIA_BUS_FMT_Y16_1X16 0x202e >> >> /* Bayer - next is 0x3021 */ >> #define MEDIA_BUS_FMT_SBGGR8_1X8 0x3001 >
