Il 07/10/22 05:17, Moudy Ho ha scritto:
In order to be compatible with more MDP3 chip settings in the future, move the chip-related configuration to a separate header file. Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx> --- .../media/platform/mediatek/mdp3/mt8183_mdp.h | 35 +++++++++++++++++++
What if we choose a better name format for the chip header? Would mdp3-plat-mt8183.h work for you? Aside from that, the changes look good... but anyway, what this driver really needs is an abstraction of `mtk-img-ipi.h` since, as you know, new SoCs are using a different firmware and even a different architecture for the MCU. Is that planned? I think that such change would perfectly fit inside of this series. Regards, Angelo
.../platform/mediatek/mdp3/mtk-mdp3-core.c | 27 ++------------ 2 files changed, 37 insertions(+), 25 deletions(-) create mode 100644 drivers/media/platform/mediatek/mdp3/mt8183_mdp.h
