Hi Dave
On Wed, Oct 05, 2022 at 04:27:54PM +0100, Dave Stevenson wrote:
> TIMING_VTS (registers 0x380e/f), EXPOSURE (registers
> 0x3500/1/2), and GAIN (0x3509) are all set from
> ov9282_update_exp_gain as part of the control handler,
> therefore they do not need to be in the main list of
> registers.
>
> Remove them.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
I don't have the datashee but I can confirm the removed registers are
programmed when setting up controls
Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
Thanks
j
> ---
> drivers/media/i2c/ov9282.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index 699fc5b753b4..2c13bcd59c2a 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -173,14 +173,10 @@ static const struct ov9282_reg mode_1280x720_regs[] = {
> {0x3030, 0x10},
> {0x3039, 0x32},
> {0x303a, 0x00},
> - {0x3500, 0x00},
> - {0x3501, 0x5f},
> - {0x3502, 0x1e},
> {0x3503, 0x08},
> {0x3505, 0x8c},
> {0x3507, 0x03},
> {0x3508, 0x00},
> - {0x3509, 0x10},
> {0x3610, 0x80},
> {0x3611, 0xa0},
> {0x3620, 0x6e},
> @@ -214,8 +210,6 @@ static const struct ov9282_reg mode_1280x720_regs[] = {
> {0x380b, 0xd0},
> {0x380c, 0x05},
> {0x380d, 0xfa},
> - {0x380e, 0x06},
> - {0x380f, 0xce},
> {0x3810, 0x00},
> {0x3811, 0x08},
> {0x3812, 0x00},
> --
> 2.34.1
>
