Re: [PATCH v14 20/34] media: subdev: Add [GS]_ROUTING subdev ioctls and operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hei,

On 30/09/2022 14:05, Sakari Ailus wrote:

@@ -191,6 +192,55 @@ struct v4l2_subdev_capability {
  /* The v4l2 sub-device supports routing and multiplexed streams. */
  #define V4L2_SUBDEV_CAP_STREAMS			0x00000002
+/*
+ * Is the route active? An active route will start when streaming is enabled
+ * on a video node.
+ */
+#define V4L2_SUBDEV_ROUTE_FL_ACTIVE		_BITUL(0)

_BITUL() will produce an unsigned long. This isn't necessary.

Please use (1U << 0) instead. Same below.

Ok. I used BIT() originally, but that, of course, isn't available in userspace...

You might also have noticed that the next flag is bit 2, not bit 1. Bit 1 was immutable route, which I dropped, but for the time being I kept the numbering to keep the ABI compatibility with my already compiled tools. I'll change that one to bit 1 in the next series, or if we decide to add a static flag, I'll add the static flag as bit 1.

 Tomi



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux