On 27/09/2022 20:46, Marek Vasut wrote: > Convert the text STMIPID02 DT bindings to YAML DT format to permit > validation of DTs using this I2C CSI-2 to CPI bridge. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > +properties: > + compatible: > + const: st,st-mipid02 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Reference to the xclk input clock. This usually goes to "clocks", but on the other hand it does not bring any value (xclk is obvious from clock-names), so I propose to skip entire description. > + items: > + - const: xclk > + > + VDDE-supply: > + description: > + Sensor digital IO supply. Must be 1.8 volts. > + > + VDDIN-supply: > + description: > + Sensor internal regulator supply. Must be 1.8 volts. > + > + reset-gpios: > + description: > + Reference to the GPIO connected to the xsdn pin, if any. > + This is an active low signal to the mipid02. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI-2 first input port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + Single-lane operation shall be <1> or <2> . > + Dual-lane operation shall be <1 2> or <2 1> . > + minItems: 1 > + maxItems: 2 Blank line > + lane-polarity: The property is "lane-polarities" > + description: > + Any lane can be inverted or not. > + minItems: 1 > + maxItems: 2 > + > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI-2 second input port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + Single-lane operation shall be <1> or <2> . > + maxItems: 1 Blank line > + lane-polarity: lane-polarities > + description: > + Any lane can be inverted or not. > + maxItems: 1 > + > + required: > + - data-lanes > + > + port@2: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Output port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-width: > + enum: [6, 7, 8, 10, 12] Blank line > + hsync-active: true > + vsync-active: true You do not need these two - they come from video-interfaces.yaml > + > + required: > + - bus-width > + > + anyOf: > + - required: > + - port@0 > + - required: > + - port@1 > + > + required: > + - port@2 > + Best regards, Krzysztof
