Hi Mikhail,
On Thu, Sep 22, 2022 at 06:23:05PM +0300, Mikhail Rudenko wrote:
>
> Hi Sakari,
>
> and thanks for reviewing this!
You're welcome!
>
> Please see my comments below:
>
> On 2022-09-22 at 09:53 GMT, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
...
> >> +static inline u32 ov4689_cal_delay(u32 cycles)
> >> +{
> >> + return DIV_ROUND_UP(cycles, OV4689_XVCLK_FREQ / 1000 / 1000);
> >
> > Please use the actual rate instead.
> >
>
> Do you mean clk_get_rate(ov4689->xvclk), right? What if we have an ACPI
Yes.
> system and xvclk is NULL here? Please explain.
There are a few ways this could work on ACPI based systems but generally
you'd have "clock-frequency" property to indicate the frequency even if
clocks themselves wouldn't be available (when controlled via ACPI)).
--
Kind regards,
Sakari Ailus
