Hi Laurent, On 21.03.2022 15:51, Laurent Pinchart wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Matching on device fwnode handles is deprecated in favour of endpoint > fwnode handles. Switch the __v4l2_async_nf_add_fwnode_remote() function > to use the latter. The match code handles backward compatibility by > falling by to the device fwnode handle, so this shouldn't introduce any > regression. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> I love the last sentence of the patch description. :) Unfortunately, recently I found that this patch breaks Exynos4 IS (FIMC) driver operation on Trats2 board (exynos4412-trats2.dts). After merging this patch I see the following errors related to the camera sensors: [ 16.038705] S5C73M3: S5C73M3 SPI probed successfully [ 16.097399] S5C73M3: Sensor type: CML0801-M017, FW version: GDFD01 [ 16.106842] S5C73M3 0-003c: Consider updating driver S5C73M3 to match on endpoints [ 16.298323] S5C73M3: probe of 0-003c failed with error -22 [ 16.343173] S5K6A3 15-0010: Consider updating driver S5K6A3 to match on endpoints [ 16.434968] S5K6A3: probe of 15-0010 failed with error -22 I'm a bit puzzled, because I don't see anything related to endpoint matching in the sensor drivers. Instead I only found that v4l2_async_nf_add_fwnode_remote() function (which is modified by this patch) is called from the drivers/media/platform/samsung/exynos4-is/media-dev.c code. Do you have any idea what is broken after this change? Could you help fixing this issue? Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
